Skip to content

Fix for issue #2524 #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Fix for issue #2524 #2529

merged 1 commit into from
Mar 24, 2017

Conversation

mattxgreen
Copy link

@mattxgreen mattxgreen commented Mar 23, 2017

Fix

Remove socket.io-client from index.html
Add socket-io-client to bower.json
Fix issue with gulpfile wiredep:client removing the string 'client' from any added packages with the word 'client' in it's name

Closes issue #2524

Adds socket-io-client to bower
Fixes issue with gulp wiredep removing the string 'client' from added packages with the word 'client' in it's name
Closes angular-fullstack#2524
@mattxgreen mattxgreen changed the title Removes socket.io-client reference from index.html Fix for issue #2524 Mar 23, 2017
@mattxgreen
Copy link
Author

The branch this PR was created from (and it's prior commit) were failing already. This update is not intended to improve the CI testing in any way.

@mattxgreen mattxgreen closed this Mar 24, 2017
@mattxgreen mattxgreen reopened this Mar 24, 2017
@Awk34 Awk34 merged commit a74a0cb into angular-fullstack:v3 Mar 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants